Generated code for Pub/Sub does not pass type checks with mypy #1092
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
🚨
This issue needs some love.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Running
mypy
on the Python Pub/Sub client produces several type check errors.The errors in the manually written code will be handled by googleapis/python-pubsub#536, but even the generated code produces a few errors on its own. The generator should produce code that passes
mypy
checks (currently onlypytype
is used).In the scope of either this or a stand-alone issue, it would also make sense to add a
mypy
CI check for the generated code (not just the code of the generator itself) to avoid future type-check regressions.Reproduction
Clone the
google-cloud-python
repo into a virtual environment, install the Pub/Sub library in editable mode, and then run the commands seen in the "sample output" section.Versions:
Sample output:
The text was updated successfully, but these errors were encountered: