Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming conflict with create_channel in 2 generated clients #1149

Closed
parthea opened this issue Jan 24, 2022 · 4 comments · Fixed by #1187
Closed

Naming conflict with create_channel in 2 generated clients #1149

parthea opened this issue Jan 24, 2022 · 4 comments · Fixed by #1187
Assignees
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Contributor

parthea commented Jan 24, 2022

Unit tests are failing in the generated client for google/cloud/video/livestream/v1 here.

Steps to reproduce

  • clone googleapis-gen and cd in to the directory google/cloud/video/livestream/v1/video-livestream-v1-py
  • run the python post processor image in the root of google/cloud/video/livestream/v1/video-livestream-v1-py using
docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo gcr.io/cloud-devrel-public-resources/owlbot-python:latest
  • run unit tests for python 3.8 with nox -s unit-3.8
  • The majority of tests fail with 'property' object is not callable

See stacktrace in screenshot below.

create_channel appears in the same class as both a property and a method. I believe this is due to the fact that there is an rpc with the name CreateChannel here which is converted to snake case as create_channel.

Screen Shot 2022-01-24 at 7 35 18 AM

@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jan 24, 2022
@parthea parthea changed the title Unit tests fail with generated client for google/cloud/video/livestream/v1 Naming conflict in generated client for google/cloud/video/livestream/v1 Jan 24, 2022
@parthea parthea changed the title Naming conflict in generated client for google/cloud/video/livestream/v1 Naming conflict with rpc in generated client for google/cloud/video/livestream/v1 Jan 24, 2022
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jan 31, 2022
@parthea
Copy link
Contributor Author

parthea commented Feb 3, 2022

This issue also exists in the generated client for eventarc v1 . See the create_channel property here.

@parthea parthea changed the title Naming conflict with rpc in generated client for google/cloud/video/livestream/v1 Naming conflict with create_channel in 2 generated clients Feb 3, 2022
@parthea
Copy link
Contributor Author

parthea commented Feb 3, 2022

cc @danoscarmike

@hkdevandla
Copy link
Member

@software-dov, @vam-google, can you please take a look? Thanks!

@software-dov
Copy link
Contributor

Working on this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
5 participants