Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure we use retry classes correctly for {unary,streaming}×{sync,async} methods #1892

Open
vchudnov-g opened this issue Dec 11, 2023 · 0 comments
Open

ensure we use retry classes correctly for {unary,streaming}×{sync,async} methods #1892

vchudnov-g opened this issue Dec 11, 2023 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@vchudnov-g
Copy link
Contributor

As per googleapis/python-api-core#528, GAPIC libraries currently have a race condition with unary async retries, which should be fixed by googleapis/python-api-core#495. And the GAPICs also do not handle the new streaming retry classes introduced in googleapis/python-api-core#495.

Once a version python-api-core with that merged PR gets released, we need to make sure that we use retries appropriately for streaming methods, in all transports. Also see this comment in that PR.
@vchudnov-g vchudnov-g added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vchudnov-g