Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support empty strings for routing headers #2273

Open
daniel-sanche opened this issue Dec 4, 2024 · 0 comments
Open

support empty strings for routing headers #2273

daniel-sanche opened this issue Dec 4, 2024 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@daniel-sanche
Copy link
Contributor

The bigtable team is requesting that we always pass the app_profile_id header, even if not set. This allows them to verify that each client does support the header, even if it's not being actively used in each request.

Currently, the gapic generator only accepts truthy headers:

        if request.app_profile_id:
            header_params["app_profile_id"] = request.app_profile_id

I think we should change that to if request.app_profile_id is not None, to accept empty string values, as is used when building the proto

@vchudnov-g vchudnov-g added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants