Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[logging] Construct and run nox sessions with logging #2286

Open
vchudnov-g opened this issue Dec 10, 2024 · 0 comments
Open

[logging] Construct and run nox sessions with logging #2286

vchudnov-g opened this issue Dec 10, 2024 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@vchudnov-g
Copy link
Contributor

In #2281, we're running presubmits with logging by setting the environment variable GOOGLE_SDK_PYTHON_LOGGING_SCOPE within the GitHub action and then running the usual nox unit tests. This works, but it means that when running locally to test for logging, we have to do the same thing. It would be easier to be able to do this via nox sessions.

In addition, logging is an inherent part of the generator and the GAPICs, so this shouldn't be external to the testing framework.

We can specify environment variables in nox via https://nox.thea.codes/en/stable/config.html#nox.sessions.Session.env

@vchudnov-g vchudnov-g added type: process A process-related concern. May include testing, release, or the like. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

2 participants