Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[logging] Optimize converting gRPC request / response payload to json #2293

Open
ohmayr opened this issue Dec 11, 2024 · 0 comments
Open

[logging] Optimize converting gRPC request / response payload to json #2293

ohmayr opened this issue Dec 11, 2024 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@ohmayr
Copy link
Contributor

ohmayr commented Dec 11, 2024

We check the type of request / response i.e. proto.Message or google.protobuf.message.Message to appropriately convert the message to json. investigate if there's a better way or if we should simply wait for next gen protobuf.
@vchudnov-g vchudnov-g added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Dec 11, 2024
@vchudnov-g vchudnov-g changed the title Convert gRPC request / response payload to json [logging] Optimize converting gRPC request / response payload to json Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@parthea @vchudnov-g @ohmayr