Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: move assertion outside of pytest.raises context in showcase tests #2101

Merged
merged 8 commits into from
Aug 27, 2024

Conversation

ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Aug 21, 2024

Fixes #2100 🦕

@ohmayr ohmayr requested a review from a team as a code owner August 21, 2024 21:38
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 21, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Aug 21, 2024
tests/system/test_error_details.py Outdated Show resolved Hide resolved
tests/system/test_error_details.py Show resolved Hide resolved
tests/system/test_error_details.py Outdated Show resolved Hide resolved
tests/system/test_error_details.py Show resolved Hide resolved
tests/system/test_error_details.py Show resolved Hide resolved
tests/system/test_unary.py Outdated Show resolved Hide resolved
tests/system/test_unary.py Show resolved Hide resolved
Copy link
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but looks good!

tests/system/test_error_details.py Outdated Show resolved Hide resolved
tests/system/test_unary.py Show resolved Hide resolved
tests/system/test_error_details.py Outdated Show resolved Hide resolved
tests/system/test_error_details.py Outdated Show resolved Hide resolved
@ohmayr ohmayr merged commit 28d3ed5 into main Aug 27, 2024
67 checks passed
@ohmayr ohmayr deleted the fix-showcase-tests branch August 27, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update showcase tests to assert conditions outside of the context manager.
3 participants