Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service config should be generated properly #54

Closed
alexander-fenster opened this issue Oct 16, 2019 · 2 comments
Closed

service config should be generated properly #54

alexander-fenster opened this issue Oct 16, 2019 · 2 comments
Assignees
@xiaozhenliu-gg5
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
Beta

Comments

@alexander-fenster
Copy link
Contributor

Right now, the service config JSON contains hardcoded values for Echo. We need to figure out the right settings for the right service.
@alexander-fenster alexander-fenster added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Oct 16, 2019
@alexander-fenster alexander-fenster added this to the Beta milestone Oct 16, 2019
@alexander-fenster
Copy link
Contributor Author

This is actually more important than anything since it really blocks using any client other than Echo :)

@xiaozhenliu-gg5 xiaozhenliu-gg5 mentioned this issue Oct 18, 2019
Merged
@alexander-fenster
Copy link
Contributor Author

Fixed by #60 and #73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaozhenliu-gg5 xiaozhenliu-gg5

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
Beta
Development

No branches or pull requests
2 participants
@alexander-fenster @xiaozhenliu-gg5