Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Fix and re-enable showcase tests #2735

Closed
michaelbausor opened this issue Apr 25, 2019 · 6 comments
Closed

Fix and re-enable showcase tests #2735

michaelbausor opened this issue Apr 25, 2019 · 6 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. Test type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@michaelbausor
Copy link
Contributor

Showcase tests were disabled in #2727 due to not being compatible with the latest changes to resource name annotations.

@evaogbe evaogbe added priority: p2 Moderately-important priority. Fix may not be included in next release. Test type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 13, 2019
@noahdietz
Copy link
Contributor

Looks like work was started to update the annotations here #131 but stalled due to micro-generator images not being updated with the api-common-proto changes. Starting there...

@noahdietz
Copy link
Contributor

Python: waiting on a release with fix

@noahdietz
Copy link
Contributor

Kotlin: I will take a shot at updating this micro-generator, but if it becomes too much of a time suck, I will merge w/o Kotlin support and wait for Joe to return

@noahdietz
Copy link
Contributor

Kotlin: the showcase CI for kotlin-smoke-test was disabled via gapic-showcase#136 temporarily. gapic-showcase#137 to track its reinstatement.

@noahdietz
Copy link
Contributor

noahdietz commented May 23, 2019

Resource annotation updates land in gapic-showcase v1.2.0

This will come in v0.2.0 because it is a breaking change to 0.1.x versions

@noahdietz
Copy link
Contributor

Looks like #2646 fixes this by re-enabling with the showcase v0.2.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. Test type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants