Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

fix: nodejs build_gen uses grpc_service_config #3206

Merged
merged 2 commits into from
May 29, 2020

Conversation

noahdietz
Copy link
Contributor

@noahdietz noahdietz commented May 28, 2020

fix: nodejs build_gen uses grpc_service_config

fix: ignore grpc_service_config unless using gapic_v2

fix: use None instead of "" when grpc_service_config is not present

cc: @alexander-fenster

fix: ignore grpc_service_config unless using gapic_v2

fix: use None instead of "" when grpc_service_config is not present
@noahdietz noahdietz requested a review from vam-google May 28, 2020 23:34
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 28, 2020
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #3206 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3206      +/-   ##
============================================
- Coverage     87.13%   87.12%   -0.01%     
  Complexity     6077     6077              
============================================
  Files           494      494              
  Lines         24051    24052       +1     
  Branches       2612     2613       +1     
============================================
  Hits          20956    20956              
- Misses         2233     2234       +1     
  Partials        862      862              
Impacted Files Coverage Δ Complexity Δ
...om/google/api/codegen/gapic/GapicGeneratorApp.java 54.09% <0.00%> (-0.45%) 6.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 116287f...216bad9. Read the comment docs.

Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though nodejs has already migrated to microgenerator completely (including bazel presubmits)

@noahdietz
Copy link
Contributor Author

though nodejs has already migrated to microgenerator completely (including bazel presubmits)

build_gen still generates the gapic_yaml attribute in nodejs_gapic_library, which is unused because the implementation of that rule is provided via gapic-generator-typescript. This fixes that.

@noahdietz noahdietz merged commit 375959e into googleapis:master May 29, 2020
@noahdietz noahdietz deleted the build-gen-retry-config branch May 29, 2020 00:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants