Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

fix: build_gen use lro gapic as lro dep #3215

Merged
merged 2 commits into from
Jun 2, 2020

Conversation

noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Jun 1, 2020

Go back to using the local (to googleapis) //google/longrunning:longrunning_go_gapic target as the LRO gapic dep for other go_gapic_library targets. googleapis/gapic-generator-go#405 fixes the shading issue that required the remote dep @com_google_cloud_go//longrunning/autogen:go_default_library be provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2020
@noahdietz noahdietz requested a review from vam-google June 1, 2020 22:05
@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #3215 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3215   +/-   ##
=========================================
  Coverage     87.12%   87.12%           
  Complexity     6077     6077           
=========================================
  Files           494      494           
  Lines         24052    24052           
  Branches       2613     2613           
=========================================
  Hits          20956    20956           
  Misses         2234     2234           
  Partials        862      862           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17fbb3b...728e376. Read the comment docs.

Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Does it mean we technically need to regenerate all BUILD.bazel files?

@noahdietz
Copy link
Contributor Author

LGTM,

Does it mean we technically need to regenerate all BUILD.bazel files?

I have a CL ready that updates all of the targets.

@noahdietz noahdietz merged commit 996bbdd into googleapis:master Jun 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants