Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

feat: add proto3_optional to proto_custom_library #3222

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

noahdietz
Copy link
Contributor

This adds the proto3_optional enablement flag to proto_custom_library
which in turn enables it in proto_library_with_info and micro-Bazel
GAPIC targets.

This adds the proto3_optional enablement flag to proto_custom_library
which in turn enables it in proto_library_with_info and micro-Bazel
GAPIC targets.
@noahdietz noahdietz requested a review from vam-google June 5, 2020 17:30
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2020
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if that works on the whole googleapis repo

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #3222 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3222      +/-   ##
============================================
- Coverage     87.13%   87.12%   -0.01%     
+ Complexity     6078     6077       -1     
============================================
  Files           494      494              
  Lines         24052    24052              
  Branches       2613     2613              
============================================
- Hits          20957    20956       -1     
  Misses         2234     2234              
- Partials        861      862       +1     
Impacted Files Coverage Δ Complexity Δ
.../java/com/google/api/codegen/discovery/Schema.java 84.34% <0.00%> (-0.51%) 42.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bc867f...4764165. Read the comment docs.

@noahdietz
Copy link
Contributor Author

bazel build //... passes in googleapis with this change (and with no uses of proto3_optional in any of the protos)

@noahdietz noahdietz merged commit 9f11f73 into googleapis:master Jun 5, 2020
@noahdietz noahdietz deleted the proto3-optional-flag branch June 5, 2020 18:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants