Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

feat: build_gen all langs use grpc_service_config #3226

Merged
merged 3 commits into from
Jun 12, 2020

Conversation

noahdietz
Copy link
Contributor

As the migration to grpc_service_config has begun, we need to make sure that subsequent runs of build_gen doesn't overwrite the changes made in migration.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2020
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #3226 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3226   +/-   ##
=========================================
  Coverage     87.12%   87.12%           
- Complexity     6076     6077    +1     
=========================================
  Files           494      494           
  Lines         24052    24052           
  Branches       2613     2613           
=========================================
+ Hits          20955    20956    +1     
  Misses         2234     2234           
+ Partials        863      862    -1     
Impacted Files Coverage Δ Complexity Δ
...e/api/codegen/transformer/InitCodeTransformer.java 95.15% <0.00%> (+0.18%) 120.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c1aa94...0cfcb7a. Read the comment docs.

Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahdietz noahdietz merged commit 22ce9a7 into googleapis:master Jun 12, 2020
@noahdietz noahdietz deleted the build_gen-retry-all branch June 12, 2020 20:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants