Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

feat: add opt_file_args to pass the file arguments to the protoc plugin #3239

Conversation

viacheslav-rostovtsev
Copy link
Member

Currently opt_args parameter allows passing the string arguments to the protoc plugin via the -<plugin>_opt= protoc command line argument. This does not allow passing the arguments that point to the files.
This PR introduces the new parameter to the proto_custom_library rule: opt_file_args
It works similarly to the plugin_file_args to allow passing the file-arguments to the protoc plugins.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 23, 2020
@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #3239 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3239      +/-   ##
============================================
- Coverage     87.12%   87.12%   -0.01%     
+ Complexity     6077     6076       -1     
============================================
  Files           494      494              
  Lines         24052    24052              
  Branches       2613     2613              
============================================
- Hits          20956    20955       -1     
  Misses         2234     2234              
- Partials        862      863       +1     
Impacted Files Coverage Δ Complexity Δ
.../java/com/google/api/codegen/discovery/Schema.java 84.34% <0.00%> (-0.51%) 42.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 550cb95...4530813. Read the comment docs.

@alexander-fenster alexander-fenster changed the title Add opt_file_args to pass the file arguments to the protoc plugin feat: add opt_file_args to pass the file arguments to the protoc plugin Jun 24, 2020
@alexander-fenster
Copy link
Contributor

@viacheslav-rostovtsev just FYI, I renamed the PR to match the conventional commit standards which is needed for a release bot. (I'll leave it to @vam-google to review)

Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please verify that it works on googleapis first (this rule is used absolutely everywherfe for the build, so changes in it must be made carefully

@viacheslav-rostovtsev viacheslav-rostovtsev merged commit cce9967 into googleapis:master Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants