Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

fix: support reroute_to_grpc_interface with grpc_service_config #3272

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

noahdietz
Copy link
Contributor

This fixes a bug when supplying a grpc_service_config for retry settings and also using the reroute_to_grpc_interface GAPIC config option. Only two APIs are known to be using this option and this change was tested against them.

The approach is slightly hacky, passing the GAPIC interface name through that declares the method being rerouted, and overriding the rerouted service name with the GAPIC interface name when looking up the retry_params assignment. The retry configs name these rerouted RPCs using the same name as the GAPIC interface name.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 2, 2020
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #3272 into master will decrease coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3272      +/-   ##
============================================
- Coverage     87.12%   87.12%   -0.01%     
- Complexity     6080     6081       +1     
============================================
  Files           494      494              
  Lines         24060    24066       +6     
  Branches       2613     2615       +2     
============================================
+ Hits          20962    20967       +5     
  Misses         2236     2236              
- Partials        862      863       +1     
Impacted Files Coverage Δ Complexity Δ
...m/google/api/codegen/config/GapicMethodConfig.java 90.34% <80.00%> (-0.37%) 25.00 <0.00> (+1.00) ⬇️
...oogle/api/codegen/config/GapicInterfaceConfig.java 81.02% <100.00%> (+0.13%) 49.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c4b62a...a212c2e. Read the comment docs.

Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahdietz noahdietz merged commit 231ad97 into googleapis:master Sep 2, 2020
@noahdietz noahdietz deleted the fix-reroute-retry-config branch September 2, 2020 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants