This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
fix: support reroute_to_grpc_interface with grpc_service_config #3272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug when supplying a
grpc_service_config
for retry settings and also using thereroute_to_grpc_interface
GAPIC config option. Only two APIs are known to be using this option and this change was tested against them.The approach is slightly hacky, passing the GAPIC interface name through that declares the method being rerouted, and overriding the rerouted service name with the GAPIC interface name when looking up the retry_params assignment. The retry configs name these rerouted RPCs using the same name as the GAPIC interface name.