This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
fix: use remote lro Go gapic instead of local #3299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #3299 +/- ##
=========================================
Coverage 87.14% 87.14%
Complexity 6105 6105
=========================================
Files 495 495
Lines 24146 24146
Branches 2628 2628
=========================================
Hits 21041 21041
Misses 2242 2242
Partials 863 863 Continue to review full report at Codecov.
|
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 19, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [2.6.2](https://www.github.com/googleapis/gapic-generator/compare/v2.6.1...v2.6.2) (2020-10-19) ### Bug Fixes * use remote lro Go gapic instead of local ([#3299](https://www.github.com/googleapis/gapic-generator/issues/3299)) ([2fe44f7](https://www.github.com/googleapis/gapic-generator/commit/2fe44f7ce21268a63e65e67818737ed5bacf7d97)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
googleapislocal LRO GAPIC target instead of the remote version incloud.google.com/gois causing some Go linker issues. We've found that if we use the remote dep instead of the local target, the Go linker doesn't complain about it. I believe this is because the remote version depends on some of the remote dependencies (in go-genproto), rather than the localgoogleapisversions of them e.g.@go_googleapis//google/api:annotations_go_proto(remote) vs.//google/api:annotations_go_proto(local).