This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
fix: PHP Use a deterministic ordering for rest placeholders #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deterministic outputs are required for automated testing of the micro-generator when comparing outputs between generators
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #3333 +/- ##
=========================================
Coverage 87.13% 87.14%
Complexity 6120 6120
=========================================
Files 495 495
Lines 24174 24176 +2
Branches 2638 2638
=========================================
+ Hits 21065 21067 +2
Misses 2242 2242
Partials 867 867
Continue to review full report at Codecov.
|
bshaffer
approved these changes
Jan 21, 2021
There was a problem hiding this comment.
This is going to be a doozy when these clients get regenerated, but I'm ok with that.
/cc @dwsupplee @jdpedrie
|
Thanks @bshaffer :) |
|
@noahdietz @miraleung if one of you could possibly review this (tiny!) PR, that'd be great :) I think it needs an actools reviewer before I can merge... |
miraleung
approved these changes
Jan 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deterministic outputs are required for automated testing of the micro-generator when comparing outputs between generators