Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

fix(python): use '\\' for string escapes #3335

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Conversation

busunkim96
Copy link
Contributor

https://blog.bazel.build/2021/01/19/bazel-4-0.html

--incompatible_restrict_string_escapes=true. Unnecessary backslashes such as \. in string literals now result in an error, instead of silently being treated as \\.. To fix the error while preserving behavior, manually add another backslash. However, the error often signals the original code needs to be updated.

@busunkim96 busunkim96 requested a review from a team as a code owner January 21, 2021 18:32
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2021
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #3335 (1d53188) into master (f74d0aa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3335   +/-   ##
=========================================
  Coverage     87.13%   87.13%           
  Complexity     6120     6120           
=========================================
  Files           495      495           
  Lines         24174    24174           
  Branches       2638     2638           
=========================================
  Hits          21065    21065           
  Misses         2242     2242           
  Partials        867      867           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f74d0aa...1d53188. Read the comment docs.

@noahdietz noahdietz merged commit e37a4b9 into master Jan 21, 2021
@noahdietz noahdietz deleted the fix-string-escapes branch January 21, 2021 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants