This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
feat: Add support for optional field in HttpJson stubs for Java
#3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR also updates the dependency to protobuf `3.15.8`, and the chagnes ini baseline files for the othe langauges but Java are caused by the update to the protobuf dependency and are not caused by the chagnes in the generator.
google-cla
bot
added
the
cla: yes
vam-google
added a commit
to vam-google/googleapis-discovery
that referenced
this pull request
Apr 29, 2021
Also update dependencies to make this repo in sync with googleapis/googleapis. Note - gax-java will have to be updated after googleapis/gapic-generator#3356 is merged and new gax-java released. - gapic-generator will have to be updated after googleapis/gapic-generator#3356 is merged. - protobuf is currently pointing to a fork with the fix for the proper optional support for java. The fix has already been merged to protobuf master but hasn't been released to the opensource yet.
miraleung
approved these changes
Apr 29, 2021
vam-google
added a commit
to googleapis/googleapis-discovery
that referenced
this pull request
Apr 29, 2021
Also update dependencies to make this repo in sync with googleapis/googleapis. Note - gax-java will have to be updated after googleapis/gapic-generator#3356 is merged and new gax-java released. - gapic-generator will have to be updated after googleapis/gapic-generator#3356 is merged. - protobuf is currently pointing to a fork with the fix for the proper optional support for java. The fix has already been merged to protobuf master but hasn't been released to the opensource yet.
yoshi-automation
added a commit
to googleapis/google-cloud-php
that referenced
this pull request
Apr 30, 2021
Also update dependencies to make this repo in sync with googleapis/googleapis. Note - gax-java will have to be updated after googleapis/gapic-generator#3356 is merged and new gax-java released. - gapic-generator will have to be updated after googleapis/gapic-generator#3356 is merged. - protobuf is currently pointing to a fork with the fix for the proper optional support for java. The fix has already been merged to protobuf master but hasn't been released to the opensource yet. Source-Author: Vadym Matsishevskyi <25311427+vam-google@users.noreply.github.com> Source-Date: Thu Apr 29 12:39:18 2021 -0700 Source-Repo: googleapis/googleapis-discovery Source-Sha: 79d57671661a6078526fd5a51e2431eb5ce53b78 Source-Link: googleapis/googleapis-discovery@79d5767
yoshi-automation
added a commit
to googleapis/python-compute
that referenced
this pull request
May 9, 2021
Also update dependencies to make this repo in sync with googleapis/googleapis. Note - gax-java will have to be updated after googleapis/gapic-generator#3356 is merged and new gax-java released. - gapic-generator will have to be updated after googleapis/gapic-generator#3356 is merged. - protobuf is currently pointing to a fork with the fix for the proper optional support for java. The fix has already been merged to protobuf master but hasn't been released to the opensource yet. Source-Author: Vadym Matsishevskyi <25311427+vam-google@users.noreply.github.com> Source-Date: Thu Apr 29 12:39:18 2021 -0700 Source-Repo: googleapis/googleapis-discovery Source-Sha: 79d57671661a6078526fd5a51e2431eb5ce53b78 Source-Link: googleapis/googleapis-discovery@79d5767
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also updates the dependency to protobuf
3.15.8, and the chagnes ini baseline files for the othe langauges but Java are caused by the update to the protobuf dependency and are not caused by the chagnes in the generator.