This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
fix: Preconditions only supports %s format #1153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preconditions
only support use of the%s
format specifier (docs) and gax-java had a%d
format specifier. This switches it to%s
.The following error showed up in bazel builds of
java_gapic_library
targets on HEAD of googleapis:I'm not sure what changed, maybe the dependency version brought was updated transiently to the later versions that throw an exception on format specifier support in
Preconditions
. Regardless, this is an easy fix.