-
Notifications
You must be signed in to change notification settings - Fork 119
fix: retain context timeouts in ServerStreamingAttemptCallable #1155
fix: retain context timeouts in ServerStreamingAttemptCallable #1155
Conversation
It has been a while since I've touched Java, so please let me know if the tests are wonky. |
Codecov Report
@@ Coverage Diff @@
## master #1155 +/- ##
=========================================
Coverage 78.65% 78.65%
- Complexity 1170 1172 +2
=========================================
Files 204 204
Lines 5195 5196 +1
Branches 417 418 +1
=========================================
+ Hits 4086 4087 +1
Misses 935 935
Partials 174 174
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Discussed offline: there might be similar changes to AttemptCallable (for Unary RPCs) necessary, but we are punting on that right now while we investigate how to move forward with changes to timeout/deadline calculation in general. The context timeout is handled slightly differently for Unary RPCs than for Server Streaming. We need to untangle some things. |
FYI @chingor13: this shouldn't have any impact on standard client use. This only comes into affect when a caller is explicitly setting a timeout on the context given to a retryable ServerStreaming call via the |
Addresses callable overwrite of
timeout
&&streamWaitTimeout
mentioned in #1144.