You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is causing downstream errors in unit tests because the settings are attempting to load credentials while the settings are being built.
This is a behavioral change. The settings object should not care about what's in the credentials provider when being asked for its configured quotaProjectId. We now will only return an explicitly configured quotaProjectId. ClientContext.create will correctly determine the correct value to use.
chingor13
changed the title
fix: defer credential loading until you ask for quotaProjectId
fix: Settings objects should not try to read quotaProjectId from credentials
Aug 5, 2020
Are we still consider to remove getting quota from credentials?
The change removes the settings objects asking the credentials for the quotaProjectId. The right headers should still be handled correctly for the requests.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yesThis human has signed the Contributor License Agreement.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is causing downstream errors in unit tests because the settings are attempting to load credentials while the settings are being built.
This is a behavioral change. The settings object should not care about what's in the credentials provider when being asked for its configured quotaProjectId. We now will only return an explicitly configured quotaProjectId. ClientContext.create will correctly determine the correct value to use.