This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
feat: relocate protobuf configurations from java-core to gax-java #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpeddada1
changed the title
meltsufin
approved these changes
Mar 31, 2022
This was referenced Mar 31, 2022
mpeddada1
changed the title
|
SonarCloud Quality Gate failed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Protobuf configuration is needed whenever a Proto object is logged or printed. This feature was initially optional and was enabled with
--feature=com.google.nativeimage.ProtobufMessageFeaturefor only tests. However, it is possible for some libraries like Spanner to log Proto objects ( as seen here) so we have to AutomaticFeature.Testing: Manually verified with java-tasks sample.
After this PR is merged and released:
--featuresetting for Protobuf feature from java-shared-config fix(java): remove protobuf feature from native profile java-shared-config#461--featuresetting for Protobuf feature from samples in