Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'type' parameter to 'warnings.ts' #1008

Closed
alicejli opened this issue May 19, 2021 · 0 comments · Fixed by #1009
Closed

Add 'type' parameter to 'warnings.ts' #1008

alicejli opened this issue May 19, 2021 · 0 comments · Fixed by #1009
Assignees
@alicejli
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@alicejli
Copy link
Contributor

As part of respecting deprecation annotations (googleapis/gapic-generator-typescript#853), we want to emit a DeprecationWarning when people attempt to use a deprecated method/service.

To do so, we want to use the 'warning' function in 'src/warnings.ts' and update it to include the type of warning to encompass DeprecationWarning.
@alicejli alicejli self-assigned this May 19, 2021
@alicejli alicejli mentioned this issue May 19, 2021
Merged
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alicejli alicejli

Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add type parameter to warn function alicejli/gax-nodejs
2 participants
@yoshi-automation @alicejli