Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support customize options for grpc-node. #1115

Merged
merged 1 commit into from
Sep 27, 2021
Merged

feat: support customize options for grpc-node. #1115

merged 1 commit into from
Sep 27, 2021

Conversation

summer-ji-eng
Copy link
Contributor

Allow end user customize grpc-node. for grpcOption to create grpc stub.

Some grpc-js users have experienced RESOURCE_EXHAUSTED errors as a result of underlying http2 sessions not being allowed to use enough memory. As of version 1.3.0, grpc-js provides a channel option called "grpc-node.max_session_memory" to adjust how much memory those sessions can use. The value is in megabytes and the default is 10. I suggest modifying that value to see if that helps.

@summer-ji-eng summer-ji-eng requested a review from a team as a code owner September 27, 2021 17:39
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 27, 2021
@summer-ji-eng summer-ji-eng added the automerge Merge the pull request once unit tests and other checks pass. label Sep 27, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 82fb0cb into main Sep 27, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the grpcOption branch September 27, 2021 17:52
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 27, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 27, 2021
@release-please
chore: release 2.26.0 (#1116)
eb9a37b 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.26.0](https://www.github.com/googleapis/gax-nodejs/compare/v2.25.4...v2.26.0) (2021-09-27)


### Features

* support customize options for grpc-node. ([#1115](https://www.github.com/googleapis/gax-nodejs/issues/1115)) ([82fb0cb](https://www.github.com/googleapis/gax-nodejs/commit/82fb0cb347211ffa511943febcb22c972f3407d3))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@murgatroid99 murgatroid99 mentioned this pull request Sep 27, 2021
Merged
@feywind feywind mentioned this pull request Oct 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@summer-ji-eng @alexander-fenster