fix: improve performance of loadProtoJSON #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summer-ji-eng
commented
Mar 3, 2022
| @@ -357,7 +357,7 @@ describe('v1beta1.EchoClient', () => { | |||
| ); | |||
| }); | |||
|
|
|||
| it.only('invokes echo with closed client', async () => { | |||
There was a problem hiding this comment.
Accidentally checked in before. Should remove only
alexander-fenster
approved these changes
Mar 4, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 8, 2022
🤖 I have created a release *beep* *boop* --- ### [2.30.1](v2.30.0...v2.30.1) (2022-03-08) ### Bug Fixes * do not depend on index.ts from fallback code ([#1201](#1201)) ([5c7ca41](5c7ca41)) * improve performance of loadProtoJSON ([#1196](#1196)) ([df8eaf9](df8eaf9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address issue #1195
Problem:
Significant time cost to create hash for proto JSON for a larget protos set. Ads as example
To improve, we have two options (thanks @avermeil's suggestions):
jsonobject to json stirng.object-hashis build on top ofcryptomodule. Usecryptodirectly.The time cost comparision using Language API: