Long not being pinned is now pulling in ESM version

[Stono]

google-gax is used by the @google-cloud libraries (eg https://github.com/googleapis/nodejs-compute/blob/main/package.json#L123).

google-gax seems to reference the library long (eg https://github.com/googleapis/gax-nodejs/blob/main/protos/operations.d.ts#L17), but that dependency is not in the package.json.

long changed to ESM in version 5, which causes our builds to currently fail with:

node_modules/google-gax/build/protos/operations.d.ts(17,23): error TS2497: This module can only be referenced with ECMAScript imports/exports by turning on the 'esModuleInterop' flag and referencing its default export.

It feels like google-gax (which isn't ESM) should pin long to 4.0.0 in order to ensure compatibility with non-esm apps, until google-gax itself switches to esm.

We've worked around this by:

  "peerDependencies": {
    "@google-cloud/compute": "3.1.2",
    "long": "4.0.0"
  }

[nolanmar511]

+1 to this.
@google-cloud/profiler is seeing test failures related to this (I assume users would be similarly impacted). My team has not explored work-arounds yet.

[lovell]

I think this might relate to the upstream issue at grpc/grpc-node#2111

[alexander-fenster]

Thank you for the report, I'm looking and will likely ping long to the non-ESM version.

[alexander-fenster]

google-gax v2.30.3 is coming soon.