Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use uppercase method name when use fetch api #1320

Merged
merged 5 commits into from
Aug 26, 2022
Merged

fix: Use uppercase method name when use fetch api #1320

merged 5 commits into from
Aug 26, 2022

Conversation

blue-hope
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1319 🦕

@blue-hope blue-hope requested a review from a team as a code owner August 22, 2022 15:58
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 22, 2022
@blue-hope blue-hope changed the title Use uppercase method name when use fetch api fix: Use uppercase method name when use fetch api Aug 22, 2022
@alexander-fenster alexander-fenster added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 23, 2022
alexander-fenster
alexander-fenster approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alexander-fenster alexander-fenster added the automerge Merge the pull request once unit tests and other checks pass. label Aug 23, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 24, 2022
@blue-hope
Copy link
Contributor Author

blue-hope commented Aug 24, 2022 •
edited
Loading

@alexander-fenster It seems that the auto merge failed because of the kokoro-ci. Do I have something to do?

@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 25, 2022
@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2022
@alexander-fenster
Copy link
Contributor

@alexander-fenster It seems that the auto merge failed because of the kokoro-ci. Do I have something to do?

No, I'll take it from here :)

@alexander-fenster alexander-fenster added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 26, 2022
@alexander-fenster alexander-fenster added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 26, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit a0360ef into googleapis:main Aug 26, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 26, 2022
@release-please release-please bot mentioned this pull request Aug 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-fenster alexander-fenster Awaiting requested review from alexander-fenster

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lowercase patch method not permitted on window fetch
3 participants
@blue-hope @alexander-fenster @yoshi-kokoro