feat: export protobuf separately, avoid loading gRPC unless needed #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
alexander-fenster
changed the title
ruyadorno
approved these changes
Aug 26, 2022
|
@alexander-fenster This seems like an interesting addition, but as a result, I'm no longer able to bundle require("google-gax/build/src/protobuf")which makes the latest version of esbuild crash with: and indeed, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a set of small fixes and new exports that will allow client libraries load just the REST version of
google-gax, without auto-loading gRPC. The first library that will immediately benefit from this is Firestore.