-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add adhoc debug logger package #1669
Conversation
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a quick look and only had really teeny nits about package name agreement
"fix": "gts fix", | ||
"prepare": "npm run compile", | ||
"precompile": "gts clean", | ||
"samples-test": "echo no samples 🙀", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a sample, should there either be a test or should this actually say no samples tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sofisl wanted to add a system test of some kind, so maybe a sample test would be the best place.
I don't have an official sample tag, and I don't know if we even want one, so I made one up as a placeholder. Any thoughts on that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I'm just "commenting out" the snippet tags. We'll need to revisit that and/or update the typeless bot later to make automatic JS sample updates possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, LGTM. However, it would be cool to see it in action in a system test, something like gax's showcase-client. But since we haven't added code into our generated libraries I could see this being more of a to-do.
Browser tests are failing because I moved them to Node 18. You can wait for this PR to be merged first, or just copy over the .kokoro/**/*browser.cfg/setup/run files from that PR. Or I could admin merge it, since it really doesn't change anything in gax - depends on the speed with which you need it! |
Soon... I can copy over the browser test config, because this will end up being used in some things that want browser support. |
This adds a new pseudo-mono-repo package for adhoc debug logging. It's meant to be pulled in across any library and/or GAPIC to provide the ability to do the equivalent of "printf debugging", but with filtering and a disable flag.
Working group spec doc available upon request :)