Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add error check for null response from API #1681

Merged
merged 3 commits into from
Dec 16, 2024
Merged

feat: add error check for null response from API #1681

merged 3 commits into from
Dec 16, 2024

Conversation

leahecole
Copy link
Contributor

Per our convo yesterday @sofisl, updated error handling in fallbackRest for null responses :)

@leahecole leahecole requested review from a team as code owners December 10, 2024 16:58
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Dec 10, 2024
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2024
@leahecole
Copy link
Contributor Author

Needs to be merged after #1679

@generated-files-bot Generated Files Bot
Copy link

generated-files-bot bot commented Dec 16, 2024 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • .kokoro/continuous/node18/browser-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/browser-test.cfg - .kokoro files are templated and should be updated in synthtool

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 16, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Dec 16, 2024
@leahecole leahecole merged commit bdfef64 into main Dec 16, 2024
21 checks passed
@leahecole leahecole deleted the null_response branch December 16, 2024 20:32
@release-please release-please bot mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sofisl sofisl sofisl approved these changes

Assignees

@sofisl sofisl

Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leahecole @sofisl @yoshi-kokoro