feat: support sending x-goog-request-params (and other extra) headers for fallback requests
#568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-ramalingam
requested review from
LibanOdowa,
alexander-fenster and
noahdietz
googlebot
added
the
cla: yes
alexander-fenster
changed the title
x-goog-request-params (and other extra) headers for browser x-goog-request-params (and other extra) headers for browser
ramya-ramalingam
force-pushed
the
ExtraHeaderStuff2
branch
from
bc33933 to
0069eb1
Compare
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
==========================================
- Coverage 79.68% 79.37% -0.31%
==========================================
Files 58 58
Lines 3760 3777 +17
Branches 300 305 +5
==========================================
+ Hits 2996 2998 +2
- Misses 697 712 +15
Partials 67 67
Continue to review full report at Codecov.
|
ramya-ramalingam
changed the title
x-goog-request-params (and other extra) headers for browser x-goog-request-params (and other extra) headers for fallback requests
alexander-fenster
suggested changes
Aug 8, 2019
noahdietz
reviewed
Aug 8, 2019
3 tasks
alexander-fenster
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed constructSettings() and createStub() to support sending extra headers (set in options) through fallback requests.