Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export CancellableStream #610

Merged
merged 4 commits into from
Oct 9, 2019
Merged

feat: export CancellableStream #610

merged 4 commits into from
Oct 9, 2019

Conversation

alexander-fenster
Copy link
Contributor

Adding some exports for TypeScript clients.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2019
@alexander-fenster alexander-fenster changed the title export CancellableStream feat: export CancellableStream Oct 8, 2019
@codecov
Copy link

codecov bot commented Oct 9, 2019 •
edited
Loading

Codecov Report

Merging #610 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #610   +/-   ##
=======================================
  Coverage   88.42%   88.42%           
=======================================
  Files          65       65           
  Lines        4129     4129           
  Branches      319      319           
=======================================
  Hits         3651     3651           
  Misses        386      386           
  Partials       92       92
Impacted Files Coverage Δ
src/index.ts 91.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f62b655...c1d98af. Read the comment docs.

xiaozhenliu-gg5
xiaozhenliu-gg5 approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@xiaozhenliu-gg5 xiaozhenliu-gg5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex

@alexander-fenster alexander-fenster merged commit 847270b into master Oct 9, 2019
@alexander-fenster alexander-fenster deleted the more-exports branch October 9, 2019 02:20
@alexander-fenster alexander-fenster restored the more-exports branch October 9, 2019 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaozhenliu-gg5 xiaozhenliu-gg5 xiaozhenliu-gg5 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-fenster @xiaozhenliu-gg5 @googlebot