fix: depend on @types/long #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-fenster
requested review from
bcoe,
JustinBeckwith and
xiaozhenliu-gg5
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #645 +/- ##
=======================================
Coverage 88.41% 88.41%
=======================================
Files 65 65
Lines 4145 4145
Branches 321 321
=======================================
Hits 3665 3665
Misses 387 387
Partials 93 93Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in googleapis/gapic-generator-typescript#118, let's just have this dependency here and not in every client library.