fix: segment in path template can contain wildcard #849
Conversation
googlebot
added
the
cla: yes
src/pathTemplate.ts
Outdated
| @@ -122,6 +122,8 @@ export class PathTemplate { | |||
| * parsed | |||
| */ | |||
| render(bindings: Bindings): string { | |||
| console.warn('bindings: ', bindings); | |||
There was a problem hiding this comment.
no debug logs please :)
There was a problem hiding this comment.
sure, I'm using this branch to test monitoring now. Will remove this once the samples-test in monitoring passes! Thanks!
xiaozhenliu-gg5
added
the
automerge
|
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
1 similar comment
|
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
bcoe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
xiaozhenliu-gg5
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #849 +/- ##
==========================================
+ Coverage 88.99% 89.00% +0.01%
==========================================
Files 38 38
Lines 6360 6368 +8
Branches 556 558 +2
==========================================
+ Hits 5660 5668 +8
Misses 697 697
Partials 3 3
Continue to review full report at Codecov.
|
monitoring now fails for this.