fix: use util.TextEncoder, util.TextDecoder for Node 10 #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #957 +/- ##
==========================================
- Coverage 88.57% 88.53% -0.04%
==========================================
Files 43 43
Lines 7036 7041 +5
Branches 557 606 +49
==========================================
+ Hits 6232 6234 +2
- Misses 794 797 +3
Partials 10 10
Continue to review full report at Codecov.
|
bcoe
approved these changes
Feb 3, 2021
|
@alexander-fenster LGTM, but it seems like we should make sure browser tests are passing for this one? |
alexander-fenster
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #947 (once more), specifically, this comment.