fix: do not consider inherited properties for transcoding #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #995 +/- ##
==========================================
+ Coverage 88.50% 88.51% +0.01%
==========================================
Files 43 43
Lines 7124 7131 +7
Branches 617 620 +3
==========================================
+ Hits 6305 6312 +7
Misses 809 809
Partials 10 10
Continue to review full report at Codecov.
|
summer-ji-eng
approved these changes
May 8, 2021
alexander-fenster
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gRPC transcoding fails into infinite recursion if we pass a protobuf.js message object (because it has a circular dependency in its prototype). We only want to consider own properties for transcoding purposes.