Refactor gRPC and Auth situation. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we discussed in googleapis/google-cloud-node#1463', many of auth parameters will be called in a initialization of the module itself and then used later. For this purpose, GAX also serves an object which keeps the auth data and handle its feature under the same context. This also offers a new dependency of google-auto-auth library instead of google-auth-library, and supports nice optional parameters like keyFile.
|
cc: @swcloud |
|
The travis failure seems unrelated (filed as #33) |
Current coverage is 92.85% (diff: 100%)@@ master #32 diff @@
==========================================
Files 8 8
Lines 966 966
Methods 129 129
Messages 0 0
Branches 208 208
==========================================
Hits 897 897
Misses 69 69
Partials 0 0
|
|
There will be a corresponding update to the GAPIC templates, right? |
|
GAPIC template change is not yet ready, but you can see the generated result at googleapis/google-cloud-node#1476 |
|
LGTM. Can you push an empty commit to force the CI to re-run, assuming the failure is just flakiness? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed in googleapis/google-cloud-node#1463,
many of auth parameters will be called in a initialization
of the module itself and then used later.
For this purpose, GAX also serves an object which keeps
the auth data and handle its feature under the same context.
This also offers a new dependency of google-auto-auth library
instead of google-auth-library, and supports nice optional parameters
like keyFile.