fix: revert header change #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
bcoe
approved these changes
Aug 28, 2019
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
==========================================
- Coverage 96.58% 96.55% -0.04%
==========================================
Files 4 4
Lines 586 580 -6
Branches 100 99 -1
==========================================
- Hits 566 560 -6
Misses 19 19
Partials 1 1
Continue to review full report at Codecov.
|
bcoe
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts my change from #158. The discussion in #156 suggests it might be a breaking change for google-api-nodejs-client users. Let's revert it for now and think about the best way to fix the problem.