Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deps)!: updates to latest TypeScript #253

Merged
merged 2 commits into from
Mar 19, 2020
Merged

feat(deps)!: updates to latest TypeScript #253

merged 2 commits into from
Mar 19, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Mar 19, 2020

BREAKING CHANGE: TypeScript introduced breaking changes in generated code in 3.7.x

@bcoe
feat(deps)!: updates to latest TypeScript
145543f 
BREAKING CHANGE: TypeScript introduced breaking changes in generated code in 3.7.x
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 19, 2020
@codecov
Copy link

codecov bot commented Mar 19, 2020 •
edited
Loading

Codecov Report

Merging #253 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
- Coverage   98.66%   98.49%   -0.17%     
==========================================
  Files           4        4              
  Lines         599      599              
  Branches      103       95       -8     
==========================================
- Hits          591      590       -1     
- Misses          8        9       +1
Impacted Files Coverage Δ
src/gaxios.ts 96.56% <0%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c9fff7...142c67a. Read the comment docs.

@bcoe bcoe merged commit 054267b into master Mar 19, 2020
@bcoe bcoe deleted the update-typescript branch March 19, 2020 17:53
yoshi-automation added a commit that referenced this pull request Apr 1, 2020
@yoshi-automation
feat(deps)!: updates to latest TypeScript (#253)
dffe87d 
054267b
commit 054267b
Author: Benjamin E. Coe <bencoe@google.com>
Date:   Thu Mar 19 10:53:44 2020 -0700

    feat(deps)!: updates to latest TypeScript (#253)

    BREAKING CHANGE: TypeScript introduced breaking changes in generated code in 3.7.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcoe @alexander-fenster @googlebot