Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: support multipart requests #491

Closed
ddelgrosso1 opened this issue May 27, 2022 · 3 comments · Fixed by #610
Closed

feature request: support multipart requests #491

ddelgrosso1 opened this issue May 27, 2022 · 3 comments · Fixed by #610
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@ddelgrosso1
Copy link
Contributor

Currently it does not appear that Gaxios supports the ability to send multipart requests. As maintainers of google-cloud/storage we would like to be able to move away from teeny-request (which does support multipart requests) as well as add the ability to do batch deletes which require multipart requests. It would be nice to add multipart requests to this library.

@ddelgrosso1 ddelgrosso1 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels May 27, 2022
@mpiorowski
Copy link

mpiorowski commented Jun 3, 2022

The same request, the documentation says that when you send data as ReadableStream, it should set the corrent content-type. I send ReadStream, so i would expect it to work, but it doesn't. To be more precise i would expect this to work:

data: fs.createReadStream(...)

@mpiorowski
Copy link

Or even when i try to put FormData into data, still not working.

@ddelgrosso1 ddelgrosso1 removed their assignment Mar 6, 2024
@ddelgrosso1 ddelgrosso1 self-assigned this Apr 2, 2024
@ddelgrosso1
Copy link
Contributor Author

I have started implementing this so reassigning myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants