feat: Add client_secret
to defaultErrorRedactor
#604
Labels
good first issue
This issue is a good place to started contributing to this repository.
priority: p3
Desirable enhancement or fix. May not be included in next release.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Is your feature request related to a problem? Please describe.
We recently realized that while some sensitive data is being filtered automatically from being logged, we see
client_secret
data fields are not. Upon some digging into thegaxios
code, I found thatdefaultErrorRedactor
is built to redact errors and is responsible for masking the rest of the fields, butclient_secret
is not handled.Describe the solution you'd like
I would like
defaultErrorRedactor
to maskclient_secret
(or maybe just any/secret/
field). This will benefit all the customers.Describe alternatives you've considered
Alternative is to implement own error redactor, duplicating the code that is already there, and mask
client_secret
too. Then we will have to use it everywhere we usegaxios
, which is error-prone since it is easy to miss places. Same goes for an alternative to redact the error object after it was already thrown.Additional context
N/A
The text was updated successfully, but these errors were encountered: