gaxios fails with jest

[adriano-di-giovanni]

The default test environment that Jest uses for testing is a browser-like one through jsdom.

The browser-like environment makes your following line of code fail:

const fetch = isBrowser() ? window.fetch : nodeFetch;

because typeof window !== 'undefined' in isBrowser() evaluates to true but window.fetch is undefined.

Maybe, you can directly check against the existence of window.fetch instead of relying on isBrowser.

If you agree, I can send you a PR to replace each and every check against isBrowser with a feature-detection check.

[adriano-di-giovanni]

I'd like to add that it is possible to change the test environment that Jest uses for testing but I think that a feature-detection style improves the quality of the check your code relies on.

[JustinBeckwith]

Greetings @adriano-di-giovanni, and thanks for the issue! Something like what you suggested sounds reasonable. I'd love a PR!

[JustinBeckwith]

🎉 This issue has been resolved in version 2.0.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀