Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support google/protobuf/compiler/plugin.proto #9

Closed
yugui opened this issue Aug 16, 2016 · 1 comment
Closed

Support google/protobuf/compiler/plugin.proto #9

yugui opened this issue Aug 16, 2016 · 1 comment
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@yugui
Copy link

yugui commented Aug 16, 2016

I would be great if this repository also contains a compiled version of google/protobuf/compiler/plugin.proto.

I expect that this repository contains the proto because it is a part of protoc distribution. So it should be common enough to store in this repository.

Currently I am using github.com/golang/protobuf/protoc-gen-go/plugin as a compiled version of the proto file but unfortunately that go package cannot coexist with google.golang.org/genproto/protobuf because both have their own instances of descriptor.proto and they collide with each other at runtime.

@pongad
Copy link
Contributor

pongad commented Apr 4, 2017

@yugui I'm sorry this flew under my radar. We overhauled the way .pb.go files in this repo are generated late last year. The coexistence problem should be solved now. Could you try again?

Due to the age of this issue, I'll close it for now. Please reopen if the problem persists.

@pongad pongad closed this as completed Apr 4, 2017
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants