Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve cyclic dependency with opencensus #351

Closed
kernle32dll opened this issue Apr 6, 2019 · 1 comment
Closed

Resolve cyclic dependency with opencensus #351

kernle32dll opened this issue Apr 6, 2019 · 1 comment
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@kernle32dll
Copy link

While looking at golang-migrate/migrate#202, I got stuck at google.golang.org/api.

While I suppose a cycling dependency is not a problem directly with go modules, it ultimately leads to including go.opencensus.io@v0.19.1, which then causes golang/lint#436 trough an old version of google.golang.org/genproto.

To be honest - I have no idea who should fix this, or how. Even if go.opencensus.io would update to google.golang.org/api@v0.3.0, that would still cycle back:

<start here> google.golang.org/api@v0.3.0
google.golang.org/api@v0.3.0 go.opencensus.io@v0.19.2
go.opencensus.io@v0.19.2 google.golang.org/api@v0.2.0
google.golang.org/api@v0.2.0 go.opencensus.io@v0.19.1
go.opencensus.io@v0.19.1 google.golang.org/genproto@v0.0.0-20181219182458-5a97ab628bfb
@jeanbza
Copy link
Member

jeanbza commented Apr 6, 2019

Thanks - we're actively working on this issue. Please continue to track in googleapis/google-cloud-go#1359.

@jeanbza jeanbza closed this as completed Apr 6, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants