Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can we move .github/workflows/ci.yaml back to synthtool's template? #1720

Open
suztomo opened this issue Feb 18, 2021 · 0 comments
Open
Labels
priority: p4 type: process A process-related concern. May include testing, release, or the like.

Comments

@suztomo
Copy link
Member

suztomo commented Feb 18, 2021

As synthtool's template does not call .kokoro/install_dependencies.sh , I had to exclude ci.yaml from synthtool's management: https://github.com/googleapis/google-api-java-client/pull/1699/files#diff-c881f5091bb23fef16e6e6da031e4268bbb11bb3404c1a2c7da8afa53c26f4ecL32.

What's missing in synthtool's template

install_dependencies is not called.

How about the following options?

  • build.sh to call install_dependencies.sh if it exists
  • GitHub actions (ci.yaml) to call install_dependencies.sh if it exists

Does install_dependencies.sh work in Windows?

Synthtool's template is missing to disable CRLF conversion.

    - name: git configuration to avoid automatic CRLF conversion
      run: |
        git config --global core.autocrlf false
        git config --global core.eol lf
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Feb 19, 2021
@chingor13 chingor13 added the type: process A process-related concern. May include testing, release, or the like. label Feb 22, 2021
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p4 type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

4 participants