-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: run the generator #1709
feat!: run the generator #1709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; although this is very much a rubber stamp.
"nock": "^10.0.6", | ||
"nunjucks": "^3.2.0", | ||
"nyc": "^14.1.1", | ||
"open": "^6.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious why we moved from opn to open.
"google-auth-library": "^3.0.0", | ||
"googleapis-common": "^0.7.0" | ||
"google-auth-library": "^4.0.0", | ||
"googleapis-common": "^2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the the most important bit right?
@@ -29,7 +29,7 @@ | |||
"webpack": "webpack" | |||
}, | |||
"dependencies": { | |||
"googleapis-common": "^0.7.0" | |||
"googleapis-common": "^2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 good to see this picked up in each package.
BREAKING CHANGE: This release has a few breaking changes.