Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: run the generator #2104

Merged
merged 2 commits into from
May 15, 2020
Merged

feat!: run the generator #2104

merged 2 commits into from
May 15, 2020

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented May 14, 2020 •
edited by JustinBeckwith
Loading

BREAKING CHANGES: This PR contains breaking changes:

@yoshi-automation
changes without context
7208d7c 
        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
@yoshi-automation
build: do not fail builds on codecov errors (#528)
0f7ee47 
Source-Author: Benjamin E. Coe <bencoe@google.com>
Source-Date: Wed May 6 13:16:18 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: be74d3e532faa47eb59f1a0eaebde0860d1d8ab4
Source-Link: googleapis/synthtool@be74d3e
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 14, 2020
@codecov
Copy link

codecov bot commented May 14, 2020 •
edited
Loading

Codecov Report

Merging #2104 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2104   +/-   ##
=======================================
  Coverage   62.97%   62.97%           
=======================================
  Files           9        9           
  Lines        1364     1364           
  Branches       61       69    +8     
=======================================
  Hits          859      859           
  Misses        505      505

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dfda8f...0f7ee47. Read the comment docs.

@JustinBeckwith JustinBeckwith changed the title build: do not fail builds on codecov errors (#528) feat!: run the generator May 15, 2020
@JustinBeckwith JustinBeckwith merged commit dca679d into master May 15, 2020
@release-please release-please bot mentioned this pull request May 15, 2020
Merged
@AdriVanHoudt
Copy link

Great to see that this list the breaking changes 🎉
A nice improvement would be to post the breaking changes list directly on the releases page/changelog.
It also seems that #2122 and #2197 have breaking changes while not being listed in the breaking changes list on the releases page/changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. context: partial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoshi-automation @AdriVanHoudt @JustinBeckwith @googlebot