-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aliases might be incompartible with PHP 7.4 Preloading feature #1976
Comments
Btw you can still "fix" this yourself my (temporary) making it a root dependency in your project for 2.7, so you wouldn't have to resort the build step. At least I would like to think so that this should work. |
@mfn I solved the conflict by adding "require": {
"google/apiclient": "2.7.2 as 2.8.0"
} to composer.json. Though I have to retest the functionality for any possible issues because of that blatant substitution 🤞 😄 |
Thank you for reporting this, I will look into how to fix it. In the meantime, you can just require "require": {
"google/apiclient": "2.7.2"
} The issue with your transitive dependency is you need to remove |
@Ttakeleif this is now fixed! Update to v.2.8.1 and you'll be all set! |
@bshaffer I can confirm the issue is fixed. |
Does this mean the class_exists line in src/aliases.php is no longer needed? Edit: Just saw this was the fix for this issue. I'm still getting a problem while running docker container php7.4-apache. I am able to avoid the issue by using 2.8.0 though. |
@snoogans235 is it possible this will fix your issue? |
@bshaffer Is this solved in 2.8.3? because I still get the warnings. |
I got the same issue again for 2.8.3 |
After merge PR preload send warnings. |
I'm not sure that this fix has been sufficient. I am running v. 2.9.1 of "google/apiclient" and I get the following output:
Can this issue perhaps be reopened? |
@nmeirik they fixed it in EDIT: seems to be an issue on my end. I had left-over directory after composer vendor directory upload. |
@nmeirik I missed your comment because this issue is closed. Were you able to get it resolved? If not can you open a new issue? Thanks. |
@bshaffer I realized that is was just a warning and not a blocker as I initially thought, so I moved on. |
There is no such thing as "warning and not a blocker". Whenever you have warnings AND ALSO a crash for which you seek support, the first question you'll get asked is "are there any warnings"? |
Environment details
Steps to reproduce
I have an issue with aliases in Symfony app optimized for PHP 7.4 preloading feature. It loads all the required classes at once and conflicts with the aliases file which leads to numerous errors like
Could you please make it optional or add checking that those classes are not defined yet?
For those who have the same issue possible solutions are
echo '<?php' > ./vendor/google/apiclient/src/aliases.php
The text was updated successfully, but these errors were encountered: