Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does UserCredentials use access_token? #157

Closed
maguro opened this issue May 17, 2018 · 2 comments · Fixed by #650
Closed

Why does UserCredentials use access_token? #157

maguro opened this issue May 17, 2018 · 2 comments · Fixed by #650
Assignees
@TimurSadykov
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@maguro
Copy link

maguro commented May 17, 2018

When UserCredentials obtains a refreshed token from credentials that were loaded from application_default_credentials.json, it uses "access_token" instead of "id_token". My Cloud Endpoints setup seems to require a base64 JWT, i.e. "id_token".

If this is a new use case, I'll be happy to submit a PR to add this capability.
@maguro
Copy link
Author

maguro commented May 18, 2018

I intend to file a PR.

@maguro maguro mentioned this issue May 19, 2018
Closed
@JustinBeckwith JustinBeckwith added 🚨 This issue needs some love. triage me I really want to be triaged. labels Jun 8, 2018
@JustinBeckwith JustinBeckwith added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. 🚨 This issue needs some love. labels Jun 20, 2018
@JustinBeckwith
Copy link
Contributor

Note: this is implemented in node.js and Python, see me or @theacodes with questions :)

@JustinBeckwith JustinBeckwith added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jun 20, 2018
@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Nov 13, 2018
@sduskis sduskis removed 🚨 This issue needs some love. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 5, 2019
@averikitsch averikitsch mentioned this issue Jul 20, 2020
Closed
@TimurSadykov TimurSadykov self-assigned this May 15, 2021
@TimurSadykov TimurSadykov mentioned this issue May 18, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimurSadykov TimurSadykov

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add Id token support for UserCredentials googleapis/google-auth-library-java
4 participants
@sduskis @maguro @JustinBeckwith @TimurSadykov